Просмотр исходного кода

完善前端提示,当协议id不存在时明确告知业务哪个id不存在

lipf 4 месяцев назад
Родитель
Сommit
5c8ff8d044

+ 8 - 9
tenant/organization/src/main/java/com/jzg/organization/service/impl/PtlAgreementServiceImpl.java

@@ -169,7 +169,8 @@ public class PtlAgreementServiceImpl extends ServiceImpl<PtlAgreementMapper, Ptl
     public AgreementVo isExistById(String id) {
         AgreementVo agreementVo = baseMapper.queryById(id);
         if (ObjectUtils.isEmpty(agreementVo)) {
-            throw new SystemException("协议id不存在!");
+            log.info("协议id不存在:id=[{}]",id);
+            throw new SystemException("协议id不存在!id=" + id);
         }
         return agreementVo;
     }
@@ -197,7 +198,7 @@ public class PtlAgreementServiceImpl extends ServiceImpl<PtlAgreementMapper, Ptl
 
         // 获取保险公司信息
         HttpResult<EsmInsCompany> result = companyClient.findById(param.getCompanyId());
-        String companyCode = "";
+        String companyCode;
         if(result.getCode() == 200 && Objects.nonNull(result.getData())){
             companyCode = result.getData().getCompanyCode();
         }else{
@@ -288,7 +289,7 @@ public class PtlAgreementServiceImpl extends ServiceImpl<PtlAgreementMapper, Ptl
         agreementCostService.removeByIds(costIds);
 
         // 删除费用关联的规则
-        if(costIds.size() > 0) {
+        if(!costIds.isEmpty()) {
             agreementCostRuleService.remove(new LambdaQueryWrapper<PtlAgreementCostRule>()
                     .in(PtlAgreementCostRule::getPtlAgreementCostId, costIds));
         }
@@ -364,8 +365,7 @@ public class PtlAgreementServiceImpl extends ServiceImpl<PtlAgreementMapper, Ptl
                 costGroup.put(ptlAgreementCost.getCoverRuleId(), costGroupList);
             }
         }
-
-        /** 复制承保规则和费用 **/
+        // 复制承保规则和费用
         this.copyRuleAndCost(costGroup,costIds,costList,newAgreement);
 
     }
@@ -404,8 +404,7 @@ public class PtlAgreementServiceImpl extends ServiceImpl<PtlAgreementMapper, Ptl
                 Collectors.groupingBy(PtlAgreementCostType::getPtlAgreementCostId));
 
         costGroup.forEach((key, value) -> {
-
-            /** 1-承保规则复制 **/
+            //1-承保规则复制
             PtlAgreementUndwrtRules agreementUndwrtRules = rulesMap.get(key);
             PtlAgreementUndwrtRules newAgreementUndwrtRules = new PtlAgreementUndwrtRules();
             BeanUtils.copyProperties(agreementUndwrtRules,newAgreementUndwrtRules);
@@ -431,7 +430,7 @@ public class PtlAgreementServiceImpl extends ServiceImpl<PtlAgreementMapper, Ptl
                 agreementUndwrtRulesAttrLinkService.saveBatch(links);
             }
 
-            /** 2-费用复制 **/
+            // 2-费用复制
             List<PtlAgreementCost> agreementCostList = costGroup.get(key);
             if(CollUtil.isNotEmpty(agreementCostList)) {
                 agreementCostList.forEach(agreementCost -> {
@@ -469,7 +468,7 @@ public class PtlAgreementServiceImpl extends ServiceImpl<PtlAgreementMapper, Ptl
 
         // 获取保险公司信息
         HttpResult<EsmInsCompany> result = companyClient.findById(param.getCompanyId());
-        String companyCode = "";
+        String companyCode;
         if(result.getCode() == 200 && Objects.nonNull(result.getData())){
             companyCode = result.getData().getCompanyCode();
         }else{